Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix folder in root with createIntermediateGroups #291

Merged
merged 1 commit into from
Apr 11, 2018
Merged

Conversation

yonaskolb
Copy link
Owner

Fixes #290

@Lutzifer
Copy link
Contributor

thank you

@Lutzifer
Copy link
Contributor

works for me.

Another (possibly) related issue:

      - path: Mintfile
        buildPhase: none
        type: file

results in

screen shot 2018-04-10 at 18 26 15

instead of being in the Root (which I would somehow have expected.

@yonaskolb
Copy link
Owner Author

Do you have createIntermediateGroups on? That's the behaviour that adds

@yonaskolb yonaskolb merged commit ba97674 into master Apr 11, 2018
@Lutzifer
Copy link
Contributor

Lutzifer commented Apr 11, 2018

It is on, but I think it should then start at the project root, not at $HOME :)

@yonaskolb
Copy link
Owner Author

Are you saying the directory where your spec is in mintTemp? Hmm.
Are you running XcodeGen with a --spec path from somewhere else, or just in that mintTemp directory?

@Lutzifer
Copy link
Contributor

Mintfile is in the project root
project root is ~/dev/mintTemp/

call is mint run yonaskolb/xcodegen@fix_root_folder xcodegen

@yonaskolb
Copy link
Owner Author

I've fixed that here #293.
Also, it's strange to add files to a target with a build phase of none, you should add them to the project. In that PR I've also added support for adding files to fileGroups, not just directories 👍

@Lutzifer
Copy link
Contributor

Lutzifer commented Apr 11, 2018

In that PR I've also added support for adding files to fileGroups, not just directories 👍

Great! Almost finished migrating our main project to XcodeGen, so I guess the number of strange situations I discover will go down a bit 😉

@yonaskolb yonaskolb deleted the fix_root_folder branch April 11, 2018 14:16
@yonaskolb
Copy link
Owner Author

No worries, keep logging them 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants